Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GEOS coverage simplify as a processing algorithm #54939

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

nyalldawson
Copy link
Collaborator

Exposes the new (in geos v12) coverage simplification tool as a processing algorithm.

Open questions:

  • should we force validation of the coverage prior to simplification? It's added slowness, but the algorithm does requires valid coverages.
  • Should the existing geometry validation check apply to coverages also? Ie we check both the feature geometry AND the coverage geometry?
Peek.2023-10-16.11-38.mp4

@nyalldawson nyalldawson added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature Frozen Feature freeze - Do not merge! labels Oct 15, 2023
@github-actions github-actions bot added this to the 3.34.0 milestone Oct 15, 2023
@pathmapper
Copy link
Contributor

pathmapper commented Oct 16, 2023

should we force validation of the coverage prior to simplification?

+1

Should the existing geometry validation check apply to coverages also? Ie we check both the feature geometry AND the coverage geometry?

-1

I'm afraid of a failing check because of the coverage for use cases where only a valid geometry is needed...

What about a dedicated coverage validation option for the Check validity processing tool?

@nyalldawson
Copy link
Collaborator Author

@pathmapper

I'm afraid of a failing check because of the coverage for use cases where only a valid geometry is needed...

Ah, I think you misunderstood. I was referring specifically to this algorithm only, making it do a forced coverage validity check if the geometry check setting is anything other then "ignore". Other non-coverage related algorithms wouldn't be changed.

What about a dedicated coverage validation option for the Check validity processing tool?

It's on its way! (I just cant get the geos coverage check method to work correctly right now 😳)

@pathmapper
Copy link
Contributor

Thanks, got it :-) Then I'm +1 to check both the feature geometry AND the coverage geometry if the geometry check setting is anything other then "ignore".

It's on its way!

👍

@nyalldawson nyalldawson removed Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Frozen Feature freeze - Do not merge! labels Nov 2, 2023
@nyalldawson nyalldawson closed this Nov 2, 2023
@nyalldawson nyalldawson reopened this Nov 2, 2023
@nyalldawson nyalldawson merged commit 601a2a6 into qgis:master Nov 2, 2023
@nyalldawson nyalldawson deleted the coverage branch November 2, 2023 12:03
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jan 21, 2024
@qgis-bot
Copy link
Collaborator

@nyalldawson

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jan 21, 2024
@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label May 7, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented May 7, 2024

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented May 7, 2024

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#9082
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants