Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making session_role in a vector layer affect rendering (issue #52085) #52106

Closed
wants to merge 2 commits into from
Closed

Making session_role in a vector layer affect rendering (issue #52085) #52106

wants to merge 2 commits into from

Conversation

NullSeile
Copy link

Description

Implementing the feature proposed in #52085 (full description of the problem and solution in the issue).

Making QgsPostgresFeatureIterator change the session_role of the postgres connection. Uses the session_role value of the layers QgsPostgresProvider.

@github-actions github-actions bot added this to the 3.32.0 milestone Mar 6, 2023
@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 21, 2023
@NullSeile
Copy link
Author

Is there anything missing in this pull request I should be adding or doing?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 21, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 5, 2023
@github-actions
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Apr 12, 2023
@MorriganR MorriganR mentioned this pull request Jun 12, 2023
Merged
@manisandro manisandro reopened this Jul 5, 2023
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 5, 2023
@manisandro manisandro closed this Jul 5, 2023
@NullSeile
Copy link
Author

Can this pull request be reviewed further?

@m-kuhn m-kuhn reopened this Aug 30, 2024
@m-kuhn
Copy link
Member

m-kuhn commented Aug 30, 2024

CC @rldhont

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 93418ee)

@rldhont
Copy link
Contributor

rldhont commented Aug 30, 2024

@NullSeile can you rebase and push force your branche ?

@NullSeile
Copy link
Author

It should be done!

@rldhont
Copy link
Contributor

rldhont commented Sep 2, 2024

The PyQgsPostgresProvider test failed. @NullSeile can you fix it ?

@nyalldawson nyalldawson added Freeze Exempt Feature Freeze exemption granted and removed backport release-3_38 labels Sep 13, 2024
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 28, 2024
@rldhont
Copy link
Contributor

rldhont commented Sep 30, 2024

@NullSeile thanks for your contibution. Can you check the PyQgsPostgresProvider ?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 30, 2024
@NullSeile
Copy link
Author

I've been trying to find the issue but I haven't manage to. I'm still working on it

@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 15, 2024
@nyalldawson nyalldawson added Frozen Feature freeze - Do not merge! and removed Freeze Exempt Feature Freeze exemption granted labels Oct 17, 2024
@NullSeile
Copy link
Author

I haven't been able to find what the issue is. Is there any way someone with more experience with QGIS development can take a look at it?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 23, 2024
@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Dec 4, 2024
@nyalldawson nyalldawson closed this Dec 9, 2024
@nyalldawson nyalldawson reopened this Dec 9, 2024
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Dec 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pka pka pka left review comments

@rldhont rldhont rldhont approved these changes

Assignees
No one assigned
Labels
backport queued_ltr_backports Queued Backports PostGIS data provider stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Milestone
3.32.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NullSeile @m-kuhn @rldhont @pka @manisandro @nyalldawson