-
-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DXF Export (app and processing) documentation #8995
Update DXF Export (app and processing) documentation #8995
Conversation
gacarrillor
commented
Apr 2, 2024
•
edited
Loading
edited
- Fix Add option 'Use only selected features' to DXF export (Request in QGIS) #8961
- Processing:
- Adjust default value for MTEXT parameter.
- Add missing parameter EXTENT.
- Add missing parameter MAP_THEME (also added to possible processing parameter values).
@DelazJ, should these icons reflect the default value for each checkbox? I'm asking because if that's the case, I could update them in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these icons reflect the default value for each checkbox?
@gacarrillor Yes, that was the idea. Thanks for fixing.
Do you also plan to clarify what the layer title refers to?
@@ -680,6 +680,7 @@ guidelines: | |||
LayoutItem ``layoutitem`` | |||
Color ``color`` | |||
Scale ``scale`` | |||
Map theme ``map theme`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary. I see the list has unnecessarily grown... The initial intent was to list available specific widgets and assign to parameters the one they used in the GUI.
Specifically, map themes are text string in a combobox, so I would just go with enumeration
but I see there is already a "maptheme" type.
I will try to revisit this in upcoming weeks. Any idea/feedback for clarification will be more than welcome in the meantime... (I must admit I'm myself confused on how these are used throughout the docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, map extent and map theme have already their own processing widgets, so IMHO when users/devs look at the docs (e.g., to replicate the widget in a custom processing algorithm), it'd be great if we could point them at the more specific widget, i.e., instead of pointing them to an enumeration, we could let them know they can/should use the more specific map theme
widget.
I'll do that in this PR.
Sure! I started by asking for some agreement here and now that the scenario is clearer we could explain a little bit both the title provenance. |
Yes! sorry for the silence, holidays... and I noticed that things were sorted out in the meantime. |
Done!
No worries, that was my first guess! :) |
Co-authored-by: Harrissou Sant-anna <[email protected]>