Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BigInt support for REST client #62

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Implement BigInt support for REST client #62

merged 3 commits into from
Mar 1, 2024

Conversation

Rendez
Copy link
Collaborator

@Rendez Rendez commented Feb 21, 2024

caused by qdrant/qdrant#3669
relates to qdrant/openapi-typescript-fetch#6
casually closes #48

Add support for BigInt on REST client via @qdrant/[email protected]. Also pins dependencies to prevent dep updates from breaking a working version.

Though previous versions point to @qdrant/openapi-typescript-fetch@^1.2.1 and will receive the dependency update, this PR formalizes support in our SDK. It also adds correct TS typings.

TypeScript types for REST

The generator isn't generating bigint types by itself, see: openapi-ts/openapi-typescript#1439

WIP (todo)

@Rendez Rendez added the enhancement New feature or request label Feb 21, 2024
@Rendez Rendez requested a review from IvanPleshkov February 21, 2024 13:15
@Rendez Rendez self-assigned this Feb 21, 2024
@Rendez Rendez marked this pull request as draft February 21, 2024 13:15
.npmrc Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Contributor

@IvanPleshkov IvanPleshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any concerns but some questions from non-TS developer =)

@Rendez
Copy link
Collaborator Author

Rendez commented Mar 1, 2024

In order to finalise this PR, we have to generate new TS types that include bigint | number where relevant. For that we need to fix the OAS definitions which will affect the C-Sharp and Python clients. Perhaps it won't break anything, but that's the next step, to check.

@Rendez Rendez marked this pull request as ready for review March 1, 2024 11:00
@generall generall merged commit 44bac2a into master Mar 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS Build error
4 participants