Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA CI: explicitly set C++20 mode for libtorrent #22245

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Feb 7, 2025

Also bump boost::asio to 1.77 (linux) since previous version has a bug that prevents compiling in C++20 mode.

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Feb 7, 2025
Boost::asio 1.76 has a bug that prevents compiling in C++20 mode.
@xavier2k6
Copy link
Member

Should the minimum boost version requirement also be raised?

@Chocobo1
Copy link
Member Author

Chocobo1 commented Feb 7, 2025

Should the minimum boost version requirement also be raised?

Not in v5.0 and v5.1. It can be done to master branch after v5.1 is branched out.
But I have no strong preference for whether it should be incremented.

@Chocobo1 Chocobo1 requested a review from a team February 7, 2025 08:57
@xavier2k6

This comment was marked as off-topic.

@glassez
Copy link
Member

glassez commented Feb 7, 2025

Should the minimum boost version requirement also be raised?

Why should we do this?
IMO, if current minimum version is still compatible with qBittorrent and new version does not fix some known critical error affecting qBittorrent, we should not artificially raise the requirements.

@xavier2k6
Copy link
Member

xavier2k6 commented Feb 7, 2025

Should the minimum boost version requirement also be raised?

Why should we do this? IMO, if current minimum version is still compatible with qBittorrent and new version does not fix some known critical error affecting qBittorrent, we should not artificially raise the requirements.

It was only an (in-general) question but appreciate the more definitive response.

EDIT: Could've rephrased the question to "Is there a need to raise minimum boost version requirement?"

@Chocobo1
Copy link
Member Author

Chocobo1 commented Feb 7, 2025

Did you have time to look into issue where Qt 6.6+ can't be used for linux ci?

I wasn't aware of it. Do you have compilation log?

@xavier2k6
Copy link
Member

I wasn't aware of it. Do you have compilation log?

I mentioned it in #20431 (comment)

Happens at Package Appimage stage

I didn't test the exclusion method as per: https://forum.qt.io/post/809214

[qt/stdout] -- Deploying module: sql -- 
[qt/stdout] Deploying Qt sqldrivers plugins 
[qt/stdout] Deploying shared library /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlodbc.so (destination: qbittorrent/usr/plugins/sqldrivers/)
[qt/stdout] WARNING: Could not find copyright files for file /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlodbc.so using dpkg-query 
[qt/stdout] Deploying dependencies for ELF file /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlodbc.so 
[qt/stdout] Deploying shared library /lib/x86_64-linux-gnu/libodbc.so.2
[qt/stdout] Deploying copyright files for file /lib/x86_64-linux-gnu/libodbc.so.2 
[qt/stdout] Deploying shared library /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/lib/libQt6Sql.so.6
[qt/stdout] WARNING: Could not find copyright files for file /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/lib/libQt6Sql.so.6 using dpkg-query 
[qt/stdout] Deploying shared library /lib/x86_64-linux-gnu/libltdl.so.7
[qt/stdout] Deploying copyright files for file /lib/x86_64-linux-gnu/libltdl.so.7 
[qt/stdout] Deploying shared library /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlmimer.so (destination: qbittorrent/usr/plugins/sqldrivers/)
[qt/stdout] WARNING: Could not find copyright files for file /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlmimer.so using dpkg-query 
[qt/stdout] Deploying dependencies for ELF file /home/runner/work/qBittorrent/Qt/6.6.0/gcc_64/plugins/sqldrivers/libqsqlmimer.so 
[qt/stdout] ERROR: Could not find dependency: libmimerapi.so 
ERROR: Failed to run plugin: qt (exit code: 1) 
Error: Process completed with exit code 1.

https://github.com/xavier2k6/qBittorrent/actions/runs/13202720026
logs_34084861380.zip

@Chocobo1
Copy link
Member Author

Chocobo1 commented Feb 7, 2025

I didn't test the exclusion method as per: https://forum.qt.io/post/809214

You should definitely try that. Seems to be the answer.

@Chocobo1 Chocobo1 merged commit dc10b88 into qbittorrent:master Feb 8, 2025
15 checks passed
@Chocobo1 Chocobo1 deleted the ci_cpp20 branch February 8, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants