-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA CI: explicitly set C++20 mode for libtorrent #22245
Conversation
Boost::asio 1.76 has a bug that prevents compiling in C++20 mode.
Should the minimum boost version requirement also be raised? |
Not in v5.0 and v5.1. It can be done to |
This comment was marked as off-topic.
This comment was marked as off-topic.
Why should we do this? |
It was only an (in-general) question but appreciate the more definitive response. EDIT: Could've rephrased the question to "Is there a need to raise minimum boost version requirement?" |
I wasn't aware of it. Do you have compilation log? |
I mentioned it in #20431 (comment) Happens at I didn't test the exclusion method as per: https://forum.qt.io/post/809214
https://github.com/xavier2k6/qBittorrent/actions/runs/13202720026 |
You should definitely try that. Seems to be the answer. |
Also bump boost::asio to 1.77 (linux) since previous version has a bug that prevents compiling in C++20 mode.