WebUI: use recommended function for checking NaN values

Also fix a few variable names along the way.
qbittorrent · Feb 10, 2025 · f0a84ad · f0a84ad
1 parent b052ad0
commit f0a84ad
Show file tree

Hide file tree

Showing 4 changed files with 233 additions and 223 deletions.
diff --git a/src/webui/www/private/scripts/dynamicTable.js b/src/webui/www/private/scripts/dynamicTable.js
@@ -1856,7 +1856,7 @@ window.qBittorrent.DynamicTable ??= (() => {
             };
             const displayDate = function(td, row) {
                 const value = this.getRowValue(row) * 1000;
-                const formattedValue = (isNaN(value) || (value <= 0)) ? "" : (new Date(value).toLocaleString());
+                const formattedValue = (Number.isNaN(value) || (value <= 0)) ? "" : (new Date(value).toLocaleString());
                 td.textContent = formattedValue;
                 td.title = formattedValue;
             };

diff --git a/src/webui/www/private/scripts/misc.js b/src/webui/www/private/scripts/misc.js
@@ -164,7 +164,7 @@ window.qBittorrent.Misc ??= (() => {
 
     const friendlyPercentage = (value) => {
         let percentage = (value * 100).round(1);
-        if (isNaN(percentage) || (percentage < 0))
+        if (Number.isNaN(percentage) || (percentage < 0))
             percentage = 0;
         if (percentage > 100)
             percentage = 100;
@@ -189,7 +189,7 @@ window.qBittorrent.Misc ??= (() => {
 
         const tryToNumber = (str) => {
             const num = Number(str);
-            return (isNaN(num) ? str : num);
+            return (Number.isNaN(num) ? str : num);
         };
 
         const ver = versionString.split(".", 4).map(val => tryToNumber(val));

diff --git a/src/webui/www/private/scripts/progressbar.js b/src/webui/www/private/scripts/progressbar.js
@@ -117,7 +117,7 @@ window.qBittorrent.ProgressBar ??= (() => {
 
     function ProgressBar_setValue(value) {
         value = parseFloat(value);
-        if (isNaN(value))
+        if (Number.isNaN(value))
             value = 0;
         value = Math.min(Math.max(value, 0), 100);
         this.vals.value = value;