Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Binder Build #64

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Fix Binder Build #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9de2396
Add a `.binder` directory for binder config
annehaley Mar 14, 2024
b6e6428
fix(binder): add `start` script to set `PYVISTA_TRAME_JUPYTER_MODE`
annehaley Apr 3, 2024
68aff59
fix: add temporary manual overrides to example notebooks
annehaley Apr 8, 2024
930902c
fix: add `zarr` to reqs for sea temps example
annehaley Apr 8, 2024
8bbbe21
style: sort `binder/requirements.txt`
annehaley Apr 8, 2024
18209a2
fix: remove `attrs` arg from `pv.read()` (removed from pyvista in 0.4…
annehaley Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .binder/postBuild
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash
pip uninstall -y vtk
pip install --extra-index-url https://wheels.vtk.org vtk-osmesa
12 changes: 12 additions & 0 deletions .binder/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
geovista
open-radar-data
protobuf==3.20.*
pyvista-xarray
siphon
tqdm
trame
trame-jupyter-extension
trame-vtk
trame-vuetify
xradar
zarr # for sea_temps example
7 changes: 7 additions & 0 deletions .binder/start
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash

# https://mybinder.readthedocs.io/en/latest/using/config_files.html#start-run-code-before-the-user-sessions-starts

export PYVISTA_TRAME_JUPYTER_MODE=extension

exec "$@"
15 changes: 14 additions & 1 deletion examples/cartographic.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,19 @@
"import xarray as xr"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "d1f8421b-9dd4-4f2f-9d7d-eafced578e58",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -79,7 +92,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
},
"vscode": {
"interpreter": {
Expand Down
15 changes: 14 additions & 1 deletion examples/data-cube.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@
"pv.set_jupyter_backend(\"server\") # critical for large data"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "9342ad3d-0966-4526-84e4-0d79badbf7a3",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "markdown",
"id": "e2f22803",
Expand Down Expand Up @@ -163,7 +176,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
15 changes: 14 additions & 1 deletion examples/introduction.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@
"import pyvista as pv"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "b108cab2-302b-45d7-aff0-d0cc34efdac9",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "markdown",
"id": "3523b485-1f8e-44af-88bb-11ec9b0b2eed",
Expand Down Expand Up @@ -139,7 +152,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
},
"vscode": {
"interpreter": {
Expand Down
15 changes: 14 additions & 1 deletion examples/lightning.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,19 @@
"pv.set_jupyter_backend(\"server\")"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "21ff7e10-b4b6-4238-8958-e43e0d492ba9",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -250,7 +263,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
15 changes: 14 additions & 1 deletion examples/radar.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,19 @@
"pv.set_jupyter_backend(\"server\")"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "1dc11e2d-e134-47f4-b0f7-d7ccf9742822",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"attachments": {},
"cell_type": "markdown",
Expand Down Expand Up @@ -163,7 +176,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
16 changes: 15 additions & 1 deletion examples/sea_temps.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,20 @@
"from pvxarray.vtk_source import PyVistaXarraySource\n"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "a6eddc4e-815c-4a32-a39a-efbfb117eafc",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"import pyvista as pv \n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -59,7 +73,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
},
"toc": {
"base_numbering": 1,
Expand Down
15 changes: 14 additions & 1 deletion examples/simple.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@
"import numpy as np"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "9bec78fd-761c-4248-984e-6d91a8fd1308",
"metadata": {},
"outputs": [],
"source": [
"# Temporary manual mode override; waiting for pyvista release including changes from https://github.com/pyvista/pyvista/pull/5798\n",
"\n",
"pv.global_theme.trame.server_proxy_enabled = False\n",
"pv.global_theme.trame.jupyter_extension_enabled = True"
]
},
{
"cell_type": "code",
"execution_count": null,
Expand Down Expand Up @@ -123,7 +136,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.17"
"version": "3.9.18"
}
},
"nbformat": 4,
Expand Down
2 changes: 0 additions & 2 deletions pvxarray/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,12 @@ def open_dataset(
filename_or_obj,
*,
drop_variables=None,
attrs=None,
force_ext=None,
file_format=None,
progress_bar=False,
):
mesh = pv.read(
filename_or_obj,
attrs=attrs,
force_ext=force_ext,
file_format=file_format,
progress_bar=progress_bar,
Expand Down
Loading