Fix LightningTimeCompositor failing when data outside of the time range is passed #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3057 +/- ##
==========================================
- Coverage 96.11% 96.11% -0.01%
==========================================
Files 383 383
Lines 55685 55680 -5
==========================================
- Hits 53523 53518 -5
Misses 2162 2162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the LightningTimeCompositor (implemented in #2895) that was causing failures when the input data contained lightning times outside of the time range.
The compositor was using
drop=Truewhen filtering lightnings outside the defined time_range. This was causing a mismatch in dimension between the lightning data array and the latitude/longitudes arrays due to the dropped entries, so that resampling operations were failing due to shape/chunks mismatch.By removing
drop=Truealso the explicit computation of the condition array could be removed.On a side, this PR also reduces the handling of empty data from an error to a warning, and fixes some language/typos in the docstrings.