Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_observer_look test for scalar case and update stickler config #91

Merged
merged 3 commits into from
Dec 20, 2021

Conversation

gerritholl
Copy link
Member

@gerritholl gerritholl commented Dec 14, 2021

Add a get_observer_look unit test when passing scalars / regular Python types.

Although #90 was a false alarm and had already been fixed in #77, it appears this may have been accidental, as no mention of this bug is made in #77 or #72. Add a unit test for passing scalars to get_observer_look to make sure we cover this case in the future.

Also updates stickler configuration to make sure it uses Python 3 and respects configuration from setup.cfg.

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #91 (104ba09) into main (cbe67e2) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   86.64%   86.67%   +0.03%     
==========================================
  Files          13       13              
  Lines        2021     2026       +5     
==========================================
+ Hits         1751     1756       +5     
  Misses        270      270              
Flag Coverage Δ
unittests 86.67% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyorbital/tests/test_orbital.py 96.28% <100.00%> (+0.06%) ⬆️
pyorbital/tlefile.py 91.06% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe67e2...104ba09. Read the comment docs.

Change the stickler configuration such that it should use Python 3 and
look into setup.cfg for detailed settings.
@gerritholl gerritholl changed the title Add get_observer_look test for scalar case Add get_observer_look test for scalar case and update stickler config Dec 15, 2021
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 70ab097 into pytroll:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants