Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to timezone aware datetimes #69

Merged
merged 9 commits into from
Jan 27, 2025

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 15, 2024

This makes Posttroll use internally timezone aware datetimes.

The tests will need additions so that both aware and unaware datetimes are used where either is passed.

Closes #64

@pnuu pnuu self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.97%. Comparing base (90ebc98) to head (02fd7ec).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
posttroll/tests/test_message.py 97.22% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   89.59%   89.97%   +0.37%     
==========================================
  Files          25       25              
  Lines        2278     2254      -24     
==========================================
- Hits         2041     2028      -13     
+ Misses        237      226      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit 77f8410 into pytroll:main Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Timezone aware datetimes
3 participants