Tests and package for GCP generation and project structure #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraspaud
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Ok, just a couple of questions for now after a quick review.
Regarding the styling, it would we nice to use ruff, maybe with these settings?
https://github.com/pytroll/satpy/blob/main/pyproject.toml#L135C1-L138C86
And for running all this automatically, pre-commit is a good tool too.
| @@ -0,0 +1 @@ | |||
| '''Main package file for georeferencer.''' | |||
| import numpy as np | ||
| from scipy import ndimage | ||
|
|
||
| #Image downsampling |
There was a problem hiding this comment.
This comment should be removed and included into the docstring instead.
Comment on lines
+201
to
+202
| # Only one maximum per group should be selected | ||
| assert result == [(1, 1), (1, 3), (3, 1), (3, 3)] |
There was a problem hiding this comment.
I'm not sure I understand here: shouldn't be only one result?
| assert result == [(2, 2)] | ||
|
|
||
| def test_thin_gcp_candidates_multiple_maxima(): | ||
| # Case where multiple maxima exist in a group |
| @@ -0,0 +1,243 @@ | |||
| #import georeferencer.gcp_generation as gcp_gen | |||
There was a problem hiding this comment.
Suggested change
| #import georeferencer.gcp_generation as gcp_gen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests and package for generating and handling ground control points.
Also added github action that runs tests.