add annotation to data loader next_batch #1907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55858614 |
xunnanxu
added a commit
to xunnanxu/torchrec
that referenced
this pull request
Apr 20, 2024
Summary: The data loader batch fetching logic isn't regular kernel related so profiler wouldn't show the actual e2e time. This would show a label instead of just leaving it blank. Differential Revision: D55858614
xunnanxu
force-pushed
the
export-D55858614
branch
from
d00ddb0 to
283cffd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55858614 |
Summary: The data loader batch fetching logic isn't regular kernel related so profiler wouldn't show the actual e2e time. This would show a label instead of just leaving it blank. Differential Revision: D55858614
xunnanxu
force-pushed
the
export-D55858614
branch
from
283cffd to
01746e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55858614 |
xunnanxu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The data loader batch fetching logic isn't regular kernel related so profiler wouldn't show the actual e2e time.
This would show a label instead of just leaving it blank.
Differential Revision: D55858614