Fix pytree flatten/unflatten for KeyedTensor #1899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56320582 |
Summary: KeyedTensor length_per_key represents size of embeddings after lookup, which are static. Reflecting that in the pytree case to help torch.export understand constraints instead of allocating new unbacked SymInts Differential Revision: D56320582
PaulZhang12
force-pushed
the
export-D56320582
branch
from
2dc9422 to
ef7e511
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56320582 |
PaulZhang12
added a commit
to PaulZhang12/torchrec
that referenced
this pull request
Apr 19, 2024
Summary: KeyedTensor length_per_key represents size of embeddings after lookup, which are static. Reflecting that in the pytree case to help torch.export understand constraints instead of allocating new unbacked SymInts Differential Revision: D56320582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D56320582