Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getNextAVFrameNoDemux() #470

Merged
merged 68 commits into from
Jan 23, 2025
Merged

Remove getNextAVFrameNoDemux() #470

merged 68 commits into from
Jan 23, 2025

Conversation

NicolasHug
Copy link
Member

Needs #469 to be landed first.

This is a shallow wrapper that is only called in one place. We now inline it to limit the number of methods.

scotts and others added 30 commits December 16, 2024 07:41
@scotts
Start implementation of approximate mode
16d698f
@scotts
Merge branch 'main' of github.com:pytorch/torchcodec into approx
9a5abce
@scotts
Initial seek mode implementation in VideoDecoder.
d95b128
@scotts
Merge branch 'main' of github.com:pytorch/torchcodec into approx
97ac764
@scotts
Added Python side support, extended tests.
35f2e59
@scotts
Apply lints
8c9aeac
@scotts
Default C++ tests to approximate mode
921b822
@scotts
Apply lints
b349282
@scotts
Updated metadata; all tests pass.
081a5bb
@scotts
Removed commened out code.
802b881
@scotts
Consolidated logic for timestamp batch. Big perf win.
911a3bc
@scotts
Consolidated logic for timestamp range.
7267b5a
@scotts
More mode consolidation.
ae44f78
@scotts
Merge branch 'main' of github.com:pytorch/torchcodec into approx
e4edaf4
@NicolasHug
Merge branch 'main' into approx
64ebefe
@scotts
Provide constructor param names
f62af46
@scotts
getFramesSize -> getNumFrames
d15dfa0
@scotts
Use seek_mode to paramterize metadata tests
8879c32
@scotts
stream -> streamInfo
8443de5
@scotts
Merge branch 'main' of github.com:pytorch/torchcodec into approx
446910d
@scotts
Merge branch 'approx' of github.com:scotts/torchcodec into approx
ebebb63
@scotts
seek -> seekMode
e34ca31
@scotts
remove getFramePlayedAtTimestampNoDemuxInternal
67c1225
@scotts
Merge branch 'main' of github.com:pytorch/torchcodec into approx
d13879d
@scotts
Rationalize time based samplers and valid metadata
06bb2c3
@scotts
Refactor setting and using scanned number of frames
8ed3c5e
@scotts
Tweak FrameInfo struct initialization
bc10db8
@scotts
Use validateFrameIndex in getFramesInIndices
a6a2b6a
@scotts @NicolasHug
Update src/torchcodec/decoders/_video_decoder.py
3cd6842 
Co-authored-by: Nicolas Hug <[email protected]>
@scotts
Tweak VideoDecoder doc string
9a46404
@NicolasHug
Lint
f247884
@NicolasHug
More videoStreamOptions
55a5840
@NicolasHug
Merge branch 'main' of github.com:pytorch/torchcodec into renamingzzzz
793c876
@NicolasHug
reduce diff
79ea167
@NicolasHug
Fix C++ tests
404b2e4
@NicolasHug
Fix CUDA?
941d6a3
@NicolasHug
Merge branch 'main' of github.com:pytorch/torchcodec into renamingzzzz
11779a7
@NicolasHug
Use allStreamMetadata
a7c5711
@NicolasHug
Rename BatchDecodedOutput into FrameBatchOutput
16d5e52
@NicolasHug
Rename RawDecodedOutput into AVFrameWithStreamIndex
78b095a
@NicolasHug
Rename DecodedOutput into FrameOutput
e1e46ff
@NicolasHug
Rename .frames into .data
cd0a181
@NicolasHug
rename .frame to .data
0111bfc
@NicolasHug
Use frameBatchOutput variable name
42ea096
@NicolasHug
rename getFrameOutputWithFilter
3a2ab2d
@NicolasHug
Use frameOutput name
05da318
@NicolasHug
lint
a6a47f1
@NicolasHug
Merge branch 'main' of github.com:pytorch/torchcodec into framezzzzz
d1352fe
@NicolasHug
getNextAVFrameNoDemux
658b727
@NicolasHug
more stuff
62818a7
@NicolasHug
use avFrameWithStreamIndex
24d0035
@NicolasHug
Cpp tests
a1805d1
@NicolasHug
more
eb1773a
@NicolasHug
Remove getNextAVFrameNoDemux
21b8ff2
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 23, 2025
@NicolasHug NicolasHug merged commit 288bb83 into pytorch:main Jan 23, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotts scotts scotts approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @scotts @facebook-github-bot