Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Remove unused-variable in pytorch/hiveio/hiveio_writer.cpp +3 #418

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Dec 2, 2024

Summary:
LLVM-15 has a warning -Wunused-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with [[maybe_unused]].

See: D66437647

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D66464240

Summary:
LLVM-15 has a warning `-Wunused-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code or (b) qualifies the variable with `[[maybe_unused]]`.

See: D66437647

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Differential Revision: D66464240
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66464240

@facebook-github-bot facebook-github-bot merged commit b0de666 into pytorch:main Dec 3, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants