Improve GPU frames accuracy #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
EDIT: out of date, just refer to updated see main comment above |
NicolasHug
changed the title
scotts
approved these changes
Dec 2, 2024
|
Wow! Great catch! Thanks @fmassa, @pjs102793 and @NicolasHug! |
NicolasHug
added a commit
to NicolasHug/torchcodec
that referenced
this pull request
Dec 4, 2024
NicolasHug
added a commit
that referenced
this pull request
Dec 4, 2024
ahmadsharif1
reviewed
Dec 6, 2024
| @@ -225,7 +225,7 @@ void convertAVFrameToDecodedOutputOnCuda( | |||
| auto start = std::chrono::high_resolution_clock::now(); | |||
| NppStatus status; | |||
| if (src->colorspace == AVColorSpace::AVCOL_SPC_BT709) { | |||
| status = nppiNV12ToRGB_709HDTV_8u_P2C3R( | |||
| status = nppiNV12ToRGB_709CSC_8u_P2C3R( | |||
There was a problem hiding this comment.
Drive-by: this should probably be gated by AVFrame::color_range.
https://ffmpeg.org/doxygen/trunk/pixfmt_8h.html#a3da0bf691418bc22c4bcbe6583ad589a
MPEG has limited color-range while JPEG has full color range.
We were using full for all frames before -- now we are using limited for all. Colorspace and color-range are orthogonal so probably need nested ifs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now call
nppiNV12ToRGB_709CSC_8u_P2C3Rfor GPU frame color conversion, instead ofnppiNV12ToRGB_709HDTV_8u_P2C3R, as suggested in #412This dramatically improves accuracy of decoded frames, as they are now much closer to the expected CPU ones, within
atol=2(this is even stricter than our frame comparison for MacOS!).Closes #412
Thank you @fmassa for the original hint in #372 (comment) and @pjs102793 for chasing this up!