This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Delegate IColumn.fill_null/drop_null to Arrow
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32770009 |
wenleix
pushed a commit
to wenleix/torcharrow
that referenced
this pull request
Dec 2, 2021
Summary: Pull Request resolved: pytorch#96 As title NOTE: the changes of diff only delegate IColumn.fill_null to Arrow since TorchArrow is using Apache Arrow 2.0.0, which doesn't support `drop_null` until Apache Arrow 6: https://arrow.apache.org/docs/python/api/compute.html#selections Reviewed By: wenleix Differential Revision: D32770009 fbshipit-source-id: 533df9e60582fe6f45266da6dac26576d6b0d5fb
wenleix
force-pushed
the
export-D32770009-to-fbsync
branch
from
dac95e3 to
347d37d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32770009 |
wenleix
pushed a commit
to wenleix/torcharrow
that referenced
this pull request
Dec 6, 2021
Summary: Pull Request resolved: pytorch#96 As title NOTE: the changes of diff only delegate IColumn.fill_null to Arrow since TorchArrow is using Apache Arrow 2.0.0, which doesn't support `drop_null` until Apache Arrow 6: https://arrow.apache.org/docs/python/api/compute.html#selections Reviewed By: wenleix Differential Revision: D32770009 fbshipit-source-id: 2fbdbf6529ba677292acbcfd78f7d256282e3561
wenleix
force-pushed
the
export-D32770009-to-fbsync
branch
from
347d37d to
5756613
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32770009 |
Summary: Pull Request resolved: pytorch#96 As title NOTE: the changes of diff only delegate IColumn.fill_null to Arrow since TorchArrow is using Apache Arrow 2.0.0, which doesn't support `drop_null` until Apache Arrow 6: https://arrow.apache.org/docs/python/api/compute.html#selections Reviewed By: wenleix Differential Revision: D32770009 fbshipit-source-id: d010b66369d5e347f06fd715eb0202ccb7e912ef
wenleix
force-pushed
the
export-D32770009-to-fbsync
branch
from
5756613 to
315aa3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32770009 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
Summary: Pull Request resolved: #96 As title NOTE: the changes of diff only delegate IColumn.fill_null to Arrow since TorchArrow is using Apache Arrow 2.0.0, which doesn't support `drop_null` until Apache Arrow 6: https://arrow.apache.org/docs/python/api/compute.html#selections Reviewed By: wenleix, OswinC Differential Revision: D32770009 fbshipit-source-id: 14ad956d406f4125b176eb5cbb65eb16492c1cd1
|
This pull request has been reverted by a7a1ed6. |
|
Related issue: #64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title
NOTE: the changes of diff only delegate IColumn.fill_null to Arrow since TorchArrow is using Apache Arrow 2.0.0, which doesn't support
drop_nulluntil Apache Arrow 6: https://arrow.apache.org/docs/python/api/compute.html#selectionsReviewed By: wenleix
Differential Revision: D32770009