Clean up portable op_topk #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison function was repeated several times. Factor it out. Differential Revision: [D67875394](https://our.internmc.facebook.com/intern/diff/D67875394/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7528
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f3b0f1 with merge base 7a2dc47 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Jan 6, 2025
The comparison function was repeated several times. Factor it out. Differential Revision: [D67875394](https://our.internmc.facebook.com/intern/diff/D67875394/) ghstack-source-id: 260406714 Pull Request resolved: #7528
|
This pull request was exported from Phabricator. Differential Revision: D67875394 |
manuelcandales
approved these changes
Jan 7, 2025
facebook-github-bot
merged commit da72e68
into
gh/swolchok/123/base
45 of 48 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
JacobSzwejbka
pushed a commit
that referenced
this pull request
Jan 7, 2025
The comparison function was repeated several times. Factor it out. Differential Revision: [D67875394](https://our.internmc.facebook.com/intern/diff/D67875394/) ghstack-source-id: 260406714 Pull Request resolved: #7528 Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The comparison function was repeated several times. Factor it out.
Differential Revision: D67875394