Cadence fusiong3 operators m2 #7490

ckmadhira · 2025-01-03T09:16:15Z

Summary

Added new operators sub, div, exp, permute, slice, mean in backends/cadence/fusion_g3
For cycle reduction, disabled error checks in operators using macro "OPT_ARG_CHECK"

pytorch-bot · 2025-01-03T09:16:19Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7490

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e79b466 with merge base a29dc49 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mcremon-meta · 2025-01-05T11:26:33Z

backends/cadence/fusion_g3/operators/op_add.cpp

-using ::executorch::aten::Scalar;
-using ::executorch::aten::ScalarType;
-using ::executorch::aten::Tensor;
-using ::executorch::runtime::canCast;
-using ::executorch::runtime::Error;
-using ::executorch::runtime::KernelRuntimeContext;
+using exec_aten::Scalar;
+using exec_aten::ScalarType;
+using exec_aten::Tensor;
+using executorch::runtime::canCast;
+using torch::executor::Error;
+using torch::executor::KernelRuntimeContext;


I think we need to retain the full ones, I'll let @hsharma35 confirm

As part of M1 release, we have used "exec_aten::Scalar" similar to what is available in HiFi. Later, I think, Zonglin in his PR has changed this. We tried to retain this. @hsharma35 and @zonglinpeng please let me know the correct name space to use.

Nit: Please use the latest namespace/headers similar to op_add.cpp in master.
The header/namespaces are using executorch c++ style guide

@hsharma35 - Updated all the operators similar to op_add.cpp in master

mcremon-meta · 2025-01-05T11:26:49Z

backends/cadence/fusion_g3/operators/op_cat.cpp

-using ::executorch::aten::ScalarType;
-using ::executorch::aten::Tensor;
-using ::executorch::runtime::Error;
-using ::executorch::runtime::KernelRuntimeContext;
+using exec_aten::Scalar;
+using exec_aten::ScalarType;
+using exec_aten::Tensor;
+using torch::executor::Error;
+using torch::executor::KernelRuntimeContext;


mcremon-meta · 2025-01-05T11:27:25Z

backends/cadence/fusion_g3/operators/op_dequantize.cpp

-using ::executorch::aten::Scalar;
-using ::executorch::aten::ScalarType;
-using ::executorch::aten::Tensor;
-using ::executorch::runtime::Error;
-using ::executorch::runtime::KernelRuntimeContext;
+using exec_aten::Scalar;
+using exec_aten::ScalarType;
+using exec_aten::Tensor;
+using torch::executor::Error;
+using torch::executor::KernelRuntimeContext;


won't put it on the other files, but same here and all new files I guess

mcremon-meta · 2025-01-05T11:28:22Z

backends/cadence/fusion_g3/operators/op_cat.cpp

@@ -30,6 +29,15 @@ namespace impl {
 namespace G3 {
 namespace native {

+#define XT_KERNEL_CHECK(ctx, out, kernel, ...) \


why is this defined so many times? We should be able to at least move it to a share location?

This PR creates a separate header for the XT_KERNEL_CHECK macro. Maybe rebase on top of this and include the common header instead? We can cleanup in a different PR too.
#7516

Change done.

facebook-github-bot · 2025-01-06T19:10:49Z

@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Added new operators sub, div, exp, permute, slice, mean in backends/cadence/fusion_g3 For cycle reduction, disabled error checks in operators using macro "OPT_ARG_CHECK" Pull Request resolved: pytorch#7490 Differential Revision: D67870337 Pulled By: zonglinpeng

hsharma35 · 2025-01-05T17:34:51Z

backends/cadence/fusion_g3/operators/op_add.cpp

+using exec_aten::Scalar;
+using exec_aten::ScalarType;
+using exec_aten::Tensor;
+using executorch::runtime::canCast;


Can we please undo the changes in headers / using declarations?
(I think this is likely due to a bad rebase)

hsharma35 · 2025-01-05T18:32:35Z

backends/cadence/fusion_g3/operators/op_cat.cpp

@@ -30,6 +29,15 @@ namespace impl {
 namespace G3 {
 namespace native {

+#define XT_KERNEL_CHECK(ctx, out, kernel, ...) \


This PR creates a separate header for the XT_KERNEL_CHECK macro. Maybe rebase on top of this and include the common header instead? We can cleanup in a different PR too.
#7516

hsharma35 · 2025-01-06T19:53:29Z

backends/cadence/fusion_g3/operators/op_native_layer_norm.cpp

+using Tensor = exec_aten::Tensor;
+using ScalarType = exec_aten::ScalarType;
+using IntArrayRef = exec_aten::ArrayRef<int64_t>;
+using torch::executor::Error;
+using torch::executor::KernelRuntimeContext;


Please undo the namespace and header changes.

Summary: Added new operators sub, div, exp, permute, slice, mean in backends/cadence/fusion_g3 For cycle reduction, disabled error checks in operators using macro "OPT_ARG_CHECK" Pull Request resolved: pytorch#7490 Differential Revision: D67870337 Pulled By: zonglinpeng

…, dequantize, cat, layer norm, softmax to backends/cadence folder. Added operators to backends/cadence folder

Signed-off-by: [email protected] <[email protected]>

…ument checks in the operators using macro

…n to support integer inputs and float output

…ckends/cadence/fusion_g3/operators to solve a comilation error

…in the operators at backends\cadence\fusion_f3\operators folder

facebook-github-bot · 2025-01-07T19:45:04Z

@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025

ckmadhira force-pushed the cadence_fusiong3_operators_M2 branch from bc5b6f0 to c77741a Compare January 3, 2025 11:03

mcremon-meta added the topic: not user facing label Jan 3, 2025

hsharma35 requested review from hsharma35, zonglinpeng and mcremon-meta January 5, 2025 07:35

mcremon-meta reviewed Jan 5, 2025

View reviewed changes

tarun292 approved these changes Jan 6, 2025

View reviewed changes

hsharma35 reviewed Jan 6, 2025

View reviewed changes

[email protected] and others added 11 commits January 7, 2025 11:45

Added Fusion G3 NN library with kernels related to add, mul, quantize…

2221f8a

…, dequantize, cat, layer norm, softmax to backends/cadence folder. Added operators to backends/cadence folder

Updated name space of the operators by appending cadence

a41efc8

Signed-off-by: [email protected] <[email protected]>

Added nnlib-FusionG3 submodule from FOSS-xtensa git space

ce89bf1

Signed-off-by: [email protected] <[email protected]>

Resolved Linter errors

9011471

Signed-off-by: [email protected] <[email protected]>

added operators for sub, slice, permute, exp, mean, div. Disabled arg…

5bdd7eb

…ument checks in the operators using macro

updated fusion g3 kernel git repo

0da167b

For div operator and for generic case, added get_compute type functio…

6802158

…n to support integer inputs and float output

added unary_ufunc_realhbbf16_to_floathbf16.cpp to the cmakelist in ba…

318f558

…ckends/cadence/fusion_g3/operators to solve a comilation error

resolved linter errors

dd1d629

resolved linter errors

c964d27

copied XT_KERNEL_CHECK to a header file and included the header file …

b626b7f

…in the operators at backends\cadence\fusion_f3\operators folder

ckmadhira force-pushed the cadence_fusiong3_operators_M2 branch from 897987e to b626b7f Compare January 7, 2025 06:41

[email protected] added 2 commits January 7, 2025 18:28

Removed conflicts in op_quantize.cpp

444958c

Name space usage is changed in the operators

e79b466

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cadence fusiong3 operators m2 #7490

Cadence fusiong3 operators m2 #7490

ckmadhira commented Jan 3, 2025 •

edited

Loading

pytorch-bot bot commented Jan 3, 2025 •

edited

Loading

mcremon-meta Jan 5, 2025

ckmadhira Jan 6, 2025

hsharma35 Jan 6, 2025

ckmadhira Jan 7, 2025

mcremon-meta Jan 5, 2025

mcremon-meta Jan 5, 2025

mcremon-meta Jan 5, 2025

hsharma35 Jan 5, 2025

ckmadhira Jan 6, 2025

facebook-github-bot commented Jan 6, 2025

hsharma35 Jan 5, 2025

hsharma35 Jan 5, 2025

hsharma35 Jan 6, 2025

facebook-github-bot commented Jan 7, 2025

Cadence fusiong3 operators m2 #7490

Are you sure you want to change the base?

Cadence fusiong3 operators m2 #7490

Conversation

ckmadhira commented Jan 3, 2025 • edited Loading

Summary

pytorch-bot bot commented Jan 3, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7490

✅ No Failures

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Jan 6, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Jan 7, 2025

ckmadhira commented Jan 3, 2025 •

edited

Loading

pytorch-bot bot commented Jan 3, 2025 •

edited

Loading