Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buck2 to 2024-12-16 #7448

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update buck2 to 2024-12-16 #7448

merged 2 commits into from
Jan 7, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Dec 27, 2024

Summary

Fixes #7425. Filed facebook/buck2#828 to make this easier in the future.

Test plan

Relying on CI. Manually confirmed that this unblocks building on Raspberry Pi 5 (though there is at least one more build break underneath).

Copy link

pytorch-bot bot commented Dec 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7448

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2764f3d with merge base 62c6346 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 27, 2024
@swolchok swolchok added release notes: devtools Changes to dev tooling, for example the debugger & profiler release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed release notes: devtools Changes to dev tooling, for example the debugger & profiler labels Jan 2, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jan 2, 2025

build-benchmark-app failure (and others?) appear to be unrelated: ```2024-12-27T17:51:57.9062520Z /Users/runner/work/_temp/44702da2-4c2d-4eb2-a2a6-7352a08c1006.sh: line 10: /Users/runner/work/_temp/github_env_12519068607: No such file or directory

Fixes #7425. Filed facebook/buck2#828 to make this easier in the future.
@swolchok
Copy link
Contributor Author

swolchok commented Jan 7, 2025

zstd: buck2-aarch64-apple-darwin-2024-12-16.zst: unsupported format

wat

@swolchok
Copy link
Contributor Author

swolchok commented Jan 7, 2025

wait, why are we fetching buck from some custom server instead of github?

@swolchok
Copy link
Contributor Author

swolchok commented Jan 7, 2025

wait, why are we fetching buck from some custom server instead of github?

https://github.com/pytorch/executorch/blob/main/.ci/scripts/setup-macos.sh#L31

contacting PT Dev Infra now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that this 3rd-party update is expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prelude versions are matched to buck versions; we have to do the update

@swolchok
Copy link
Contributor Author

swolchok commented Jan 7, 2025

test-demo-ios has been red for weeks. ignoring and landing.

@swolchok swolchok merged commit 6c9b9b6 into main Jan 7, 2025
120 of 121 checks passed
@swolchok swolchok deleted the update-buck2 branch January 7, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
4 participants