-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buck2 to 2024-12-16 #7448
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7448
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2764f3d with merge base 62c6346 (): BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
build-benchmark-app failure (and others?) appear to be unrelated: ```2024-12-27T17:51:57.9062520Z /Users/runner/work/_temp/44702da2-4c2d-4eb2-a2a6-7352a08c1006.sh: line 10: /Users/runner/work/_temp/github_env_12519068607: No such file or directory
|
Fixes #7425. Filed facebook/buck2#828 to make this easier in the future.
wat |
wait, why are we fetching buck from some custom server instead of github? |
https://github.com/pytorch/executorch/blob/main/.ci/scripts/setup-macos.sh#L31 contacting PT Dev Infra now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm that this 3rd-party update is expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prelude versions are matched to buck versions; we have to do the update
test-demo-ios has been red for weeks. ignoring and landing. |
Summary
Fixes #7425. Filed facebook/buck2#828 to make this easier in the future.
Test plan
Relying on CI. Manually confirmed that this unblocks building on Raspberry Pi 5 (though there is at least one more build break underneath).