-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix executorch kv cache incompatibility with to_executorch lowering #7279
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7279
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a2b7ee3 with merge base 3ef78ee (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d538d43
to
ee2eb15
Compare
ee2eb15
to
46ea733
Compare
5dcb8f7
to
f723fe1
Compare
f723fe1
to
9e68531
Compare
693bbbc
to
0597d3a
Compare
0597d3a
to
8145cda
Compare
if initialize_buffer: | ||
assert is_mutable_buffer | ||
spec.const = True | ||
else: | ||
spec.const = not (is_user_input or is_mutable_buffer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for this logic; tests that would have broken before this fix, and would have caught this kv cache incompatibility
@@ -0,0 +1,31 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for this new file
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary
Fix the Llama 3.2 vision text decoder prefill issue by marking the kv cache as an initialized mutable buffer in a custom pass
Test plan