Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc-build.yml #3071

Closed
wants to merge 2 commits into from
Closed

Update doc-build.yml #3071

wants to merge 2 commits into from

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Apr 16, 2024

Move noindex logic to the build job

Move noindex logic to the build job
Copy link

pytorch-bot bot commented Apr 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3071

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ccb2a48 with merge base c73bfc0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2024
@facebook-github-bot
Copy link
Contributor

@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@svekars svekars requested a review from clee2000 April 16, 2024 23:08
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also change the old one to search in RUNNER_ARTIFACT_DIR if you don't want to move it to the build job

@svekars
Copy link
Contributor Author

svekars commented Apr 16, 2024

I thought about it but there is really no difference I think.

@facebook-github-bot
Copy link
Contributor

@svekars merged this pull request in 5d7949d.

@svekars
Copy link
Contributor Author

svekars commented Apr 17, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 17, 2024
Summary:
Move noindex logic to the build job

Pull Request resolved: #3071

Reviewed By: clee2000

Differential Revision: D56218857

Pulled By: svekars

fbshipit-source-id: 69dff489d98eee046d69185a6c03d62fbae37a16
(cherry picked from commit 5d7949d)
@pytorchbot
Copy link
Collaborator

Cherry picking #3071

The cherry pick PR is at #3099

Details for Dev Infra team Raised by workflow job

guangy10 pushed a commit that referenced this pull request Apr 18, 2024
Summary:
Move noindex logic to the build job

Pull Request resolved: #3071

Reviewed By: clee2000

Differential Revision: D56218857

Pulled By: svekars

fbshipit-source-id: 69dff489d98eee046d69185a6c03d62fbae37a16
(cherry picked from commit 5d7949d)

Co-authored-by: Svetlana Karslioglu <[email protected]>
This was referenced Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants