Add xnnpack to llama runner mac & linux CI job #2677

lucylq · 2024-03-26T01:09:54Z

Summary: Remake of D55290786, which is ghstack poisoned

Differential Revision: D55349949

pytorch-bot · 2024-03-26T01:09:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2677

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 0b1e68c with merge base 08b644f ():

NEW FAILURE - The following job has failed:

Apple / upload-frameworks-ios (gh)
Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Apple / test-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 74
Lint / lintrunner / linux-job (gh)
>>> Lint for examples/models/llama2/export_llama_lib.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-03-26T01:10:03Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Differential Revision: D55349949

facebook-github-bot · 2024-03-26T01:10:43Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T03:15:07Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T03:15:48Z

This pull request was exported from Phabricator. Differential Revision: D55349949

mcr229 · 2024-03-26T05:21:57Z

.github/workflows/pull.yml

@@ -90,6 +90,7 @@ jobs:
      matrix:
        dtype: [fp32]
        build-tool: [buck2, cmake]
+        mode: [portable, xnnpack]


can we select quant mode rather than portable/xnnpack? Right now this is choosing xnnpack but its actually quantizing the model. Instead I think we should have quant mode be what's selected, and XNNPACK will be the quantized backend which runs it.

Let's update in follow on, as we also want the pt2e quant path.

mcr229 · 2024-03-26T05:22:54Z

examples/models/llama2/CMakeLists.txt

-                      $<TARGET_FILE:optimized_native_cpu_ops_lib> \
-                      LINKER:--no-whole-archive")
+  list(APPEND link_libraries optimized_native_cpu_ops_lib optimized_kernels
+    portable_kernels)


portable kernels is linked regardless of optimized? Can we move this outside of the if?

Hmn, optimized_native_cpu_ops_lib contains portable and optimized kernel registrations. If we don't have an optimized version of an op that's used by the model, we take the portable one.

mcr229 · 2024-03-26T05:23:30Z

examples/models/llama2/CMakeLists.txt

-                      "SHELL:LINKER:--whole-archive \
-                      $<TARGET_FILE:portable_ops_lib> \
-                      LINKER:--no-whole-archive")
+  target_link_options_shared_lib(portable_ops_lib)
 endif()

 target_link_libraries(llama_main PUBLIC gflags llama_runner)


can we add executorch here as well? This lib dep contains prim ops which need to be registered via target_link_options_shared_lib

thanks - good catch

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T06:32:01Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T06:33:04Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T17:00:54Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T17:01:23Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-26T22:49:42Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T00:30:20Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T00:31:40Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T06:55:04Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T06:55:54Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T07:15:09Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T07:15:56Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T17:44:09Z

This pull request was exported from Phabricator. Differential Revision: D55349949

Summary: Remake of D55290786, which is ghstack poisoned bypass-github-export-checks Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

facebook-github-bot · 2024-03-27T19:21:30Z

This pull request has been merged in 66c5fc8.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2024

facebook-github-bot added the fb-exported label Mar 26, 2024

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

0dbc491

Summary: Remake of D55290786, which is ghstack poisoned Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from f49ebe3 to 0dbc491 Compare March 26, 2024 01:10

digantdesai approved these changes Mar 26, 2024

View reviewed changes

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

275304c

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 0dbc491 to 275304c Compare March 26, 2024 03:15

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

f9f5dd6

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 275304c to f9f5dd6 Compare March 26, 2024 03:15

mcr229 reviewed Mar 26, 2024

View reviewed changes

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

d244721

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from f9f5dd6 to d244721 Compare March 26, 2024 06:31

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

edb6eeb

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from d244721 to edb6eeb Compare March 26, 2024 06:32

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

eba55e5

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from edb6eeb to eba55e5 Compare March 26, 2024 17:00

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

31e03d3

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from eba55e5 to 31e03d3 Compare March 26, 2024 17:01

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

dc9cdcf

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 26, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

256d19a

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from cbc28a6 to 256d19a Compare March 26, 2024 22:49

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

9baa0fa

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 256d19a to 9baa0fa Compare March 27, 2024 00:30

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

cbedd85

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 9baa0fa to cbedd85 Compare March 27, 2024 00:31

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

e190519

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from cbedd85 to e190519 Compare March 27, 2024 06:54

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

7a0aafc

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from e190519 to 7a0aafc Compare March 27, 2024 06:55

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

6ea379e

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 7a0aafc to 6ea379e Compare March 27, 2024 07:14

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

dce6601

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from 6ea379e to dce6601 Compare March 27, 2024 07:15

Add xnnpack to llama runner mac & linux CI job (pytorch#2677)

0b1e68c

Summary: Remake of D55290786, which is ghstack poisoned Reviewed By: kimishpatel, digantdesai Differential Revision: D55349949

lucylq force-pushed the export-D55349949 branch from dce6601 to 0b1e68c Compare March 27, 2024 17:43

facebook-github-bot closed this in 66c5fc8 Mar 27, 2024

facebook-github-bot added the Merged label Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xnnpack to llama runner mac & linux CI job #2677

Add xnnpack to llama runner mac & linux CI job #2677

lucylq commented Mar 26, 2024

pytorch-bot bot commented Mar 26, 2024 •

edited

Loading

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

mcr229 Mar 26, 2024

lucylq Mar 26, 2024

mcr229 Mar 26, 2024

lucylq Mar 26, 2024

mcr229 Mar 26, 2024

lucylq Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

Add xnnpack to llama runner mac & linux CI job #2677

Add xnnpack to llama runner mac & linux CI job #2677

Conversation

lucylq commented Mar 26, 2024

pytorch-bot bot commented Mar 26, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2677

❌ 1 New Failure, 2 Unrelated Failures

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

mcr229 Mar 26, 2024

Choose a reason for hiding this comment

lucylq Mar 26, 2024

Choose a reason for hiding this comment

mcr229 Mar 26, 2024

Choose a reason for hiding this comment

lucylq Mar 26, 2024

Choose a reason for hiding this comment

mcr229 Mar 26, 2024

Choose a reason for hiding this comment

lucylq Mar 26, 2024

Choose a reason for hiding this comment

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 26, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

facebook-github-bot commented Mar 27, 2024

pytorch-bot bot commented Mar 26, 2024 •

edited

Loading