Skip to content

Commit

Permalink
Upgrade actions/download-artifact@v4 (#7573)
Browse files Browse the repository at this point in the history
* Upgrade actions/download-artifact@v4

* Address actions/upload-artifact#480
  • Loading branch information
huydhn authored Jan 9, 2025
1 parent b63d9fa commit 478198b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/apple-perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ jobs:
runs-on: linux.2xlarge
steps:
- name: Download the apps from GitHub
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
# The name here needs to match the name of the upload-artifact parameter
name: ios-apps
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/apple.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 90
secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD
upload-artifact: ios-apps
upload-artifact: ios-demo-app
script: |
set -eux
Expand Down Expand Up @@ -83,10 +83,10 @@ jobs:
runs-on: linux.2xlarge
steps:
- name: Download the artifacts from GitHub
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
# The name here needs to match the name of the upload-artifact parameter
name: ios-apps
name: ios-demo-app
path: ${{ runner.temp }}/artifacts/

- name: Verify the artifacts
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
role-to-assume: arn:aws:iam::308535385114:role/gha_executorch_upload-frameworks-ios
aws-region: us-east-1
- name: Download the artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
# NB: The name here needs to match the upload-artifact name from build-frameworks-ios job
name: executorch-frameworks-ios
Expand Down Expand Up @@ -291,7 +291,7 @@ jobs:
python-version: '3.11'
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
upload-artifact: ios-apps
upload-artifact: ios-benchmark-app
secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_BENCHMARK_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD
timeout: 90
script: |
Expand Down

0 comments on commit 478198b

Please sign in to comment.