Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SamplerWrapper node #1357

Merged
merged 48 commits into from
Nov 8, 2024
Merged

Add SamplerWrapper node #1357

merged 48 commits into from
Nov 8, 2024

Conversation

andrewkho
Copy link
Contributor

@andrewkho andrewkho commented Nov 7, 2024 •
edited
Loading

Changes

  • Adds a new SamplerWrapper node which will track epochs and call set_epoch on sampler.
  • Default epoch increment behaviour can be changed by callback

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2024
@andrewkho andrewkho changed the base branch from main to andrewkh/add-state-management November 7, 2024 17:58
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1357

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7e6e948 with merge base 1fcd5e1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@andrewkho andrewkho changed the base branch from andrewkh/add-state-management to main November 7, 2024 19:43
divyanshk
divyanshk approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewkho andrewkho mentioned this pull request Nov 8, 2024
Open
@andrewkho andrewkho merged commit 0263d58 into main Nov 8, 2024
45 checks passed
@andrewkho andrewkho deleted the andrewkh/add-sampler-wrapper branch November 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshk divyanshk divyanshk approved these changes

@ramanishsingh ramanishsingh Awaiting requested review from ramanishsingh

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkho @divyanshk @facebook-github-bot