Properly handle observed noise in AdditiveMapSaasSingleTaskGP with outcome transforms #2763
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70785752 |
|
This pull request was exported from Phabricator. Differential Revision: D70785752 |
sdaulton
force-pushed
the
export-D70785752
branch
from
7ace0b2 to
669a062
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18705 18705
=======================================
Hits 18704 18704
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 7, 2025
…tcome transforms (pytorch#2763) Summary: Currently the noise is not transformed properly when there are outcome transforms (e.g. `Standardize`). This was very problematic for model fitting. This also updates the default outcome transform to match `SingleTaskGP` Reviewed By: saitcakmak Differential Revision: D70785752
sdaulton
force-pushed
the
export-D70785752
branch
from
669a062 to
1be1e7f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70785752 |
sdaulton
force-pushed
the
export-D70785752
branch
from
1be1e7f to
f162b48
Compare
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 7, 2025
…tcome transforms (pytorch#2763) Summary: Pull Request resolved: pytorch#2763 Currently the noise is not transformed properly when there are outcome transforms (e.g. `Standardize`). This was very problematic for model fitting. This also updates the default outcome transform to match `SingleTaskGP` Reviewed By: saitcakmak Differential Revision: D70785752
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Mar 7, 2025
…tcome transforms (pytorch#2763) Summary: Currently the noise is not transformed properly when there are outcome transforms (e.g. `Standardize`). This was very problematic for model fitting. This also updates the default outcome transform to match `SingleTaskGP` Reviewed By: saitcakmak Differential Revision: D70785752
sdaulton
force-pushed
the
export-D70785752
branch
from
f162b48 to
554dbb0
Compare
…tcome transforms (pytorch#2763) Summary: Pull Request resolved: pytorch#2763 Currently the noise is not transformed properly when there are outcome transforms (e.g. `Standardize`). This was very problematic for model fitting. This also updates the default outcome transform to match `SingleTaskGP` Reviewed By: saitcakmak Differential Revision: D70785752
|
This pull request was exported from Phabricator. Differential Revision: D70785752 |
sdaulton
force-pushed
the
export-D70785752
branch
from
554dbb0 to
d925d92
Compare
|
This pull request has been merged in a79b050. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently the noise is not transformed properly when there are outcome transforms (e.g.
Standardize). This was very problematic for model fitting.This also updates the default outcome transform to match
SingleTaskGPDifferential Revision: D70785752