handle constraints in qSimpleRegret #2141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51964703 |
sdaulton
added a commit
to sdaulton/botorch
that referenced
this pull request
Dec 8, 2023
Summary: This fixes two issues: 1. `constraints` could be passed to `qSimpleRegret`, but would error out if the objective was negative. 2. `constraints` were not used in the input constructor for `qSimpleRegret` in any fashion. This now enforces that constraints cannot be passed to `qSimpleRegret`, and instead, they must be passed via a `ConstrainedMCObjective`. This diff also constructs the appropriate `ConstrainedMCObjective` in the input constructor. Differential Revision: D51964703
sdaulton
force-pushed
the
export-D51964703
branch
from
349e3b8 to
586652e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51964703 |
Summary: This fixes two issues: 1. `constraints` could be passed to `qSimpleRegret`, but would error out if the objective was negative. 2. `constraints` were not used in the input constructor for `qSimpleRegret` in any fashion. This now enforces that constraints cannot be passed to `qSimpleRegret`, and instead, they must be passed via a `ConstrainedMCObjective`. This diff also constructs the appropriate `ConstrainedMCObjective` in the input constructor. Reviewed By: Balandat Differential Revision: D51964703
sdaulton
force-pushed
the
export-D51964703
branch
from
586652e to
7ba4cb9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51964703 |
|
This pull request has been merged in b717268. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes two issues:
constraintscould be passed toqSimpleRegret, but would error out if the objective was negative.constraintswere not used in the input constructor forqSimpleRegretin any fashion.This now enforces that constraints cannot be passed to
qSimpleRegret, and instead, they must be passed via aConstrainedMCObjective. This diff also constructs the appropriateConstrainedMCObjectivein the input constructor.Differential Revision: D51964703