-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ruff PLE (Pylint Error) #13305
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
What do we do if we're writing stubs for a library that really does invalidly declare a special method? It's happened before. We'd be in a tough spot there: we'd either have to |
We've had "unfixable" cases like that, I can namely remember around I'd be very surprised, but if we add stubs for a library that does it on purpose, and often. Let's say overloads builtin dunders to add params and explicitly calls those methods instead of using keywords ( In other words, I think it's a rare/niche enough case and we have an escape hatch in case it does happen. |
Ref #13295
https://docs.astral.sh/ruff/rules/#error-e_1
This did found seemingly incorrect dunders in stubs that couldn't be caught by stubtest