Hide GPG column if no GPG signatures in release #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCoffee
approved these changes
Nov 15, 2024
sethmlarson
approved these changes
Nov 15, 2024
|
https://www.python.org/downloads/release/python-201/ looks good to me now! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PEP 761 ("Deprecating PGP signatures for CPython artifacts") has been accepted and means we will no longer provide PGP signatures for Python 3.14 and later. Verifiers are recommended to use Sigstore instead.
Let's hide the GPG column from the download page's files table when there are no such files in the release.
I considered hiding the column when the version
>= (3, 14), but went for this approach because it will also hide the column for very old releases which don't have GPG files, such as https://www.python.org/downloads/release/python-201/, which I think is also useful?cc @sethmlarson