-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash from NamedTuple placeholder #18351
Draft
hauntsaninja
wants to merge
1
commit into
python:master
Choose a base branch
from
hauntsaninja:fix-crash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#17396 I'm having trouble writing a regression test, but the following reproduces the issue nicely: ``` rm -rf repro mkdir repro mkdir repro/np echo 'from .arraysetops import UniqueAllResult' > repro/np/__init__.pyi echo ' from typing import Generic, NamedTuple, TypeVar from np import does_not_exist _SCT = TypeVar("_SCT", bound=does_not_exist) class UniqueAllResult(NamedTuple, Generic[_SCT]): values: int ' > repro/np/arraysetops.pyi touch repro/np/py.typed PYTHONPATH=repro mypy -c 'import np' ```
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit hacky, but I guess it may be a necessary evil. Two things:
- Is there the same issue with generic TypedDicts? If yes, please fix that as well (and maybe try adding a test)
- Can you verify that a pattern like this still works? (And maybe add a corresponding test if we don't have one):
T = TypeVar("T", bound="NT")
class NT(NamedTuple, Generic[T]):
parent: T
item: int
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 1, 2025
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 1, 2025
Thanks for the review!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17396
I'm having trouble writing a regression test, but the following reproduces the issue nicely: