Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): set github_token variable with github.token as default #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(action): set github_token variable with github.token as default #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121bd42
perf(action): set `github_token` variable with `github.token` as default
codejedi365 Sep 30, 2024
bf1aaac
test: update test harness to match github_token default in action def…
codejedi365 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ inputs:
GitHub token used to upload artifacts. Requires permission to create and
edit releases.
required: true
default: ${{ github.token }}

root_options:
description: |
Expand Down
1 change: 0 additions & 1 deletion tests/suite/test_publish_w_tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ test_with_tag() {
local test_name="Test with tag"

# Create expectations & set env variables that will be passed in for Docker command
local WITH_VAR_GITHUB_TOKEN="ghp_1x2x3x4x5x6x7x8x9x0x1x2x3x4x5x6x7x8x9x0"
local WITH_VAR_TAG="v1.0.0"
local WITH_VAR_ROOT_OPTIONS="--noop -vv"
local expected_psr_cmd=".*/bin/semantic-release $WITH_VAR_ROOT_OPTIONS publish --tag $WITH_VAR_TAG"
Expand Down
1 change: 0 additions & 1 deletion tests/suite/test_publish_wo_tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ test_without_tag() {
local test_name="Test without tag"

# Create expectations & set env variables that will be passed in for Docker command
local WITH_VAR_GITHUB_TOKEN="ghp_1x2x3x4x5x6x7x8x9x0x1x2x3x4x5x6x7x8x9x0"
local WITH_VAR_ROOT_OPTIONS="--noop -vv"
local expected_psr_cmd=".*/bin/semantic-release $WITH_VAR_ROOT_OPTIONS publish"

Expand Down
1 change: 1 addition & 0 deletions tests/utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ run_test() {
local test_name="$1"

# Set Defaults based on action.yml
[ -z "$WITH_VAR_GITHUB_TOKEN" ] && local WITH_VAR_GITHUB_TOKEN="ghp_1x2x3x4x5x6x7x8x9x0x1x2x3x4x5x6x7x8x9x0"
[ -z "$WITH_VAR_DIRECTORY" ] && local WITH_VAR_DIRECTORY="."
[ -z "$WITH_VAR_ROOT_OPTIONS" ] && local WITH_VAR_ROOT_OPTIONS="-v"

Expand Down