test: enforce tmp working directory #9149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
enforce-working-directory
branch
3 times, most recently
from
8b5285d to
157b564
Compare
This change ensures that working director when executing a test is set to `tmp_path` fixture value. Additionally, we introduce the `set_project_context` fixture that allows for test cases to switch cwd to the required fixture project (copied to `tmp_path` by default) to ensure correct source files are used. Previously, some tests accidentally picked up incorrect pyproject.toml files as a result.
abn
force-pushed
the
enforce-working-directory
branch
from
157b564 to
fc1ca46
Compare
Secrus
requested changes
Mar 14, 2024
Secrus
approved these changes
Mar 14, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that working director when executing a test is set to
tmp_pathfixture value.Additionally, we introduce the
set_project_contextfixture that allows for test cases to switch cwd to the required fixture project (copied totmp_pathby default) to ensure correct source files are used. Previously, some tests accidentally picked up incorrect pyproject.toml files as a result.