Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/env: handle removal of in-project venv #9118

Merged
merged 1 commit into from
Mar 10, 2024
Merged

cli/env: handle removal of in-project venv #9118

merged 1 commit into from
Mar 10, 2024

Conversation

abn
Copy link
Member

@abn abn commented Mar 5, 2024

Resolves: #2124

@abn abn requested a review from a team March 5, 2024 21:31
@abn abn added area/cli Related to the command line area/docs Documentation issues/improvements impact/docs Contains or requires documentation changes labels Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-gsmnyi7ls-python-poetry.vercel.app

Built with commit 1098ab1.
This pull request is being automatically deployed with vercel-action

radoering
radoering previously approved these changes Mar 9, 2024
View reviewed changes
@abn
Copy link
Member Author

abn commented Mar 9, 2024

@Secrus has requested a hold. Awaiting review comments from him.

Secrus
Secrus reviewed Mar 9, 2024
View reviewed changes
Copy link
Member

@Secrus Secrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, had to double check if I understand the logic behind env removal. Only one nitpick from me.

src/poetry/utils/_compat.py Show resolved Hide resolved
@abn
Copy link
Member Author

abn commented Mar 9, 2024

@Secrus @radoering should be ready for review again.

@abn abn merged commit 834f131 into python-poetry:main Mar 10, 2024
36 checks passed
@abn abn deleted the issue/2124 branch March 10, 2024 02:38
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radoering radoering radoering left review comments

@Secrus Secrus Secrus approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
area/cli Related to the command line area/docs Documentation issues/improvements impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poetry env remove with virtualenvs.in-project = true
4 participants
@abn @eamanu @Secrus @radoering