Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload modules loaded dynamically during test #933

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Jan 12, 2024

  • modules loaded dynamically are now reloaded instead of deleted; deleting them caused some unexpected behavior in django
  • if reloading failed delete the module as last ressort

fixes #932

Tasks

  • Unit tests added that reproduce the issue or prove feature is working - I was not able to create a reliable test so far
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors

- modules loaded dynamically are now reloaded instead
  of deleted; deleting them caused some unexpected behavior
  in django
- if reloading failed delete the module as last ressort
@mrbean-bremen mrbean-bremen merged commit fb97b62 into pytest-dev:main Jan 12, 2024
65 checks passed
@mrbean-bremen mrbean-bremen deleted the reload-dyn branch February 26, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing with pyfakefs and django after first test
1 participant