Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes _access_token login issue #48

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Aug 7, 2024

Motivation:

Fixes #47 - Users were getting the previous user's data from a stale _access_token

All Submissions:

* [ ] Have you followed the guidelines in our Contributing document? Document should point here: https://github.com/pysnippet/instructions?tab=readme-ov-file#contributing

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you updated the documentation related to the changes you have made?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally? (Will try tomorrow)

@ArtyomVancyan
Copy link
Member

Although I thought the access token should be cached to be accessed more than once, it caused issues. I believe this caching can be implemented outside of the package if needed. So, after locally testing your changes, I agree with those. These changes will be included in the upcoming release.

@ArtyomVancyan
Copy link
Member

@mrharpo, please permit me to change your branch to update the related documents and merge the pull request. You should tick the "Allow edits from maintainers." checkbox when creating the PR, but you can edit and update it now, I believe.

@mrharpo
Copy link
Contributor Author

mrharpo commented Aug 8, 2024

@ArtyomVancyan Apparently, there's no "Allow edits from maintainers" option for github organizations, which is where I forked this.

I've added you as a maintainer to our repo. Please make whatever changes you need, and let me know if I need to add another maintainer or if there's anything else I can do to help. Thanks!

@ArtyomVancyan ArtyomVancyan merged commit c7ca1ce into pysnippet:master Aug 8, 2024
12 checks passed
@ArtyomVancyan ArtyomVancyan deleted the 47-access-token branch August 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report - _access_token cache leads to wrong user being logged in
2 participants