Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_missing option to derive macro #256

Merged
merged 5 commits into from
Feb 15, 2025
Merged

Conversation

lirannl
Copy link
Contributor

@lirannl lirannl commented Jan 4, 2025

This can be helpful (but should not be enabled by default) for certain use cases.

Since it's off by default, it shouldn't compromise the safety of this macro.

@pyrossh
Copy link
Owner

pyrossh commented Jan 8, 2025

Thanks @lirannl. A test case for this attribute would be good.

@lirannl
Copy link
Contributor Author

lirannl commented Feb 13, 2025

I can write a single runtime unit test - but that's only whether it has 0 items when you try to use it on a non-existing folder.

Other than that, I'd need something like trybuild to do a compile-time test (make sure it fails to compile without the attribute, and succeeds with it)

@pyrossh
Copy link
Owner

pyrossh commented Feb 15, 2025

LGTM. Thanks @lirannl!

@pyrossh pyrossh merged commit 769f661 into pyrossh:master Feb 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants