Type annotate pyro.nn.module
#3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
requested changes
Mar 11, 2024
pyro/nn/module.py
Outdated
|
|
||
|
|
||
| class PyroSample(namedtuple("PyroSample", ("prior",))): | ||
| @dataclass |
There was a problem hiding this comment.
Can we use @dataclass(slots=True, frozen=True) here, to remain closer to namedtuple? Of course we'll then need to use object._setattribute__(self, "foo", bar) rather than self.foo = bar in __post_init__.
There was a problem hiding this comment.
slots seems to be new in Python 3.10
pyro/nn/module.py
Outdated
| def __setattr__( | ||
| self, | ||
| name: str, | ||
| value: Union[torch.Tensor, torch.nn.Module, PyroParam, PyroSample], |
There was a problem hiding this comment.
value should have type Any, since we fall back to super.__setattr__(name, value) at the last line of this method.
There was a problem hiding this comment.
Interesting. Is that why mypy thinks torch.nn.Modules attributes are either Tensor or Module because they annotated them as such 🤔 ? That always confused me.
Comment on lines
-66
to
-68
| [mypy-pyro.nn.*] | ||
| ignore_errors = True | ||
| warn_unused_ignores = True |
fritzo
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.