Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement substitute() using anf() #523

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Reimplement substitute() using anf() #523

merged 3 commits into from
Apr 12, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Apr 9, 2021 •
edited
Loading

Blocking #414 (for performance reasons)
group coded with @eb8680 @ordabayevy @fehiepsi

@fritzo
Copy link
Member Author

fritzo commented Apr 9, 2021

Looks like this is failing at

pytest -x test/pyro/test_hmm.py::test_gaussian_mrf_log_prob

fritzo
fritzo commented Apr 12, 2021
View reviewed changes
Copy link
Member Author

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @eb8680!

@eb8680 eb8680 merged commit 402f590 into master Apr 12, 2021
@eb8680 eb8680 deleted the fast-subs branch April 12, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
awaiting review refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @eb8680