Skip to content

Commit

Permalink
new certificate from azure trusted signing
Browse files Browse the repository at this point in the history
all good except last step
> Invalid tenant id provided. You can locate your tenant id by following the instructions listed here: https://learn.microsoft.com/partner-center/find-ids-and-domain-names (Parameter 'tenantId')
  • Loading branch information
jmcouffin authored Jan 30, 2025
1 parent 1484dfb commit a90b688
Showing 1 changed file with 46 additions and 27 deletions.
73 changes: 46 additions & 27 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,15 @@ jobs:
run: |
pipenv run pyrevit set year
- name: Update Certificate
if: (github.repository == env.MainRepo)
env:
CERTIFICATE: ${{ secrets.CERTIFICATE }}
CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
run: |
pipenv run pyrevit sign addcert
# - name: Update Certificate
# if: (github.repository == env.MainRepo)
# env:
# CERTIFICATE: ${{ secrets.CERTIFICATE }}
# CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
# CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
# CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
# run: |
# pipenv run pyrevit sign addcert

# WIP only
- name: Update Build Info (WIP)
Expand Down Expand Up @@ -132,32 +132,51 @@ jobs:
with:
path: release/version

- name: Sign Products
if: (github.repository == env.MainRepo)
env:
CERTIFICATE: ${{ secrets.CERTIFICATE }}
CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
run: |
pipenv run pyrevit sign products
# - name: Sign Products
# if: (github.repository == env.MainRepo)
# env:
# CERTIFICATE: ${{ secrets.CERTIFICATE }}
# CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
# CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
# CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
# run: |
# pipenv run pyrevit sign products

- name: Build Installers
run: |
pipenv run pyrevit build installers
- name: Sign Installers
if: (github.repository == env.MainRepo)
env:
CERTIFICATE: ${{ secrets.CERTIFICATE }}
CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
run: |
pipenv run pyrevit sign installers
# - name: Sign Installers
# if: (github.repository == env.MainRepo)
# env:
# CERTIFICATE: ${{ secrets.CERTIFICATE }}
# CERTIFICATEPASSWORD: ${{ secrets.PASSWORD }}
# CERTIFICATESHA1: "${{ secrets.CERTIFICATESHA1 }}"
# CERTIFICATENAME: "${{ secrets.CERTIFICATENAME }}"
# run: |
# pipenv run pyrevit sign installers

# default retention period is 90 days
# https://github.com/marketplace/actions/upload-a-build-artifact#retention-period

- name: Sign files with Trusted Signing
if: (github.repository == env.MainRepo)
uses: azure/[email protected]
with:
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
azure-client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}
endpoint: ${{ secrets.AZURE_ENDPOINT }}
trusted-signing-account-name: ${{ secrets.AZURE_CODE_SIGNING_NAME }}
certificate-profile-name: ${{ secrets.AZURE_CERT_PROFILE_NAME }}

# Sign all exes inside the folder
files-folder: dist/
files-folder-filter: exe,msi,nupkg
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256

- name: Upload Installers
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit a90b688

Please sign in to comment.