Align structure of the components with PyPSA consistency checks #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekatef
changed the title
davide-f
reviewed
Jan 21, 2025
scripts/base_network.py
Outdated
| @@ -492,6 +492,10 @@ def base_network( | |||
| lines_ac = lines[lines.tag_frequency.astype(float) != 0].copy() | |||
| lines_dc = lines[lines.tag_frequency.astype(float) == 0].copy() | |||
|
|
|||
| # avoiding the conflicts in processing the network model | |||
There was a problem hiding this comment.
Instead of dropping tag_frequency here, we could drop it in build_osm_nwtwork and rely on the "dc" column in base_networl instead.
What do you think?
In build osm, we have both the dc and tag_frequency columns that are passed to base_network.
Probably, we can drop tag frequency in build and rely on dc column
There was a problem hiding this comment.
Ahh, I see! We now have calculation of dc column directly in clean_osm script, so it's basically a duplication in base_network! Agree, no need then to keep tag_frequency up to base_network. Thanks a lot for checking it!
Revised 🙂
davide-f
approved these changes
Jan 21, 2025
|
Thanks @ekatef :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution of the issues caused by AssertionErrors in PyPSA, like #1308.
Changes proposed in this Pull Request
The updated PyPSA version has more strict requirements towards the component structure which can easily lead to errors in case when
n.linesandn.busescontains any "extra" fields. The PR aims to drop all the columns afterbase_networkto make the workflow more robust.Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.