Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX to sensfunc fluxed std QA #1898

Merged
merged 6 commits into from
Feb 11, 2025
Merged

HOTFIX to sensfunc fluxed std QA #1898

merged 6 commits into from
Feb 11, 2025

Conversation

debora-pe
Copy link
Collaborator

The QA plot for the fluxed standard star, which is generated as a check when the sensitivity function is computed, was showing some inconsistency in the comparison with the true (archived) flux. The reason for this was that the flux was not telluric corrected. Now the telluric correction is applied. See attached example before (left) and after (right) these changes.
Screen Shot 2025-02-06 at 11 19 34 AM

Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also add a comment in the release doc 😄

Copy link
Collaborator

@jhennawi jhennawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debora-pe

@debora-pe debora-pe merged commit 932b7dd into develop Feb 11, 2025
26 checks passed
@debora-pe debora-pe deleted the sens_fixes branch February 11, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants