Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to mask the portion of a slit/order that is more than 50% outside the detector. This is done, simply, by changing the values of
specmin
andspecmax
during slit tracing. This approach allows to avoid funny behaviors during the object extraction where the portion of the slit/order that is on the detector becomes smaller and smaller.This masking is not done by default but a new parameter
mask_off_detector
has been introduced and it is set to True by default only for keck_hires.Tests already run and pass. One unit test failure is my machine usual problem with setup_gui.
FAILED ../../../Pypeit/PypeIt-development-suite/unit_tests/test_setup_gui.py::test_pypeit_obslog_model - PermissionError: [Errno 1] Operation not permitted: '/private/var/folders/x...