New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance in _manylinux.py #869

Open

cthoyt wants to merge 2 commits into pypa:main from cthoyt:patch-2

cthoyt commented Jan 31, 2025 •

edited

Loading

This PR makes a few performance improvements:

Reduces the doubled call to _is_compatible(arch, glibc_version)
Moves the assignment of the tag variable directly into the yield, reducing memory allocation in case this is never used when _is_compatible(arch, glibc_version) is false
Uses an assignment expression for dictionary lookup

cthoyt added 2 commits

January 31, 2025 12:38


          Improve performance in _manylinux.py

e44f20f


          Use assignment expression to reduce a line

bbfb63c

cthoyt mentioned this pull request

Improve performance of uv-python crate's manylinux submodule astral-sh/uv#11131

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet