Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the specification with PEP 639 #1662

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Update the specification with PEP 639 #1662

merged 10 commits into from
Jan 14, 2025

Conversation

befeleme
Copy link
Contributor

@befeleme befeleme commented Nov 19, 2024

@befeleme

This comment was marked as outdated.

@befeleme befeleme marked this pull request as draft November 19, 2024 12:15
@befeleme
Copy link
Contributor Author

befeleme commented Nov 19, 2024

@befeleme befeleme force-pushed the pep639 branch 3 times, most recently from e652a7e to f5baeba Compare November 19, 2024 15:05
@webknjaz webknjaz added the type: enhancement A self-contained enhancement or new feature label Nov 20, 2024
source/glossary.rst Outdated Show resolved Hide resolved
source/glossary.rst Outdated Show resolved Hide resolved
source/glossary.rst Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

@befeleme I've added code suggestions with :file: into a few places, but I'd like to ask you to also apply the same technique in other places that I've missed.

@befeleme
Copy link
Contributor Author

I addressed the review points in the fixup commits for better readability (will squash them later once we get closer to merging). I still walk through the pages looking for the gaps. Thank you for the sphinx tips, that's very helpful!

@befeleme befeleme force-pushed the pep639 branch 2 times, most recently from 22a449c to 4c81d90 Compare November 26, 2024 11:54
@befeleme befeleme marked this pull request as ready for review November 26, 2024 11:59
@befeleme
Copy link
Contributor Author

I think it's ready.

@befeleme
Copy link
Contributor Author

Is there anything I can do to make this move forward?

@befeleme

This comment was marked as resolved.

Copy link

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @befeleme!

source/tutorials/packaging-projects.rst Outdated Show resolved Hide resolved
source/guides/writing-pyproject-toml.rst Outdated Show resolved Hide resolved
source/guides/writing-pyproject-toml.rst Outdated Show resolved Hide resolved
source/specifications/pyproject-toml.rst Show resolved Hide resolved
source/specifications/pyproject-toml.rst Outdated Show resolved Hide resolved
source/guides/licensing-examples-and-user-scenarios.rst Outdated Show resolved Hide resolved
source/guides/licensing-examples-and-user-scenarios.rst Outdated Show resolved Hide resolved
source/guides/licensing-examples-and-user-scenarios.rst Outdated Show resolved Hide resolved
@webknjaz

This comment was marked as resolved.

befeleme and others added 6 commits January 7, 2025 11:27
Copied and adapted from PEP 639.
Redefine the license key, add license-files, mention that license
classifiers are deprecated now.
…P 639

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@befeleme befeleme force-pushed the pep639 branch 2 times, most recently from 22f7db0 to 8ea46cc Compare January 7, 2025 10:37
Copy link
Member

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, so I'm taking the view that any further edits and clarifications that folks identify post merge can be tackled in a new PR.

@ncoghlan ncoghlan enabled auto-merge January 14, 2025 12:04
@ncoghlan
Copy link
Member

Thanks for the extensive PR @befeleme, and the thorough reviews, all!

@ncoghlan ncoghlan added this pull request to the merge queue Jan 14, 2025
Merged via the queue into pypa:main with commit afceaff Jan 14, 2025
7 checks passed
@webknjaz
Copy link
Member

@ncoghlan thanks for merging! I was struggling to find time for a thorough final review myself…

@ncoghlan
Copy link
Member

ncoghlan commented Jan 14, 2025

@webknjaz I admit there was an element of "the goal is 'better than the status quo, not perfect''' in my own final review. I almost put it off again due to the PR size, realised other reviewers were probably doing the same thing, and decided it was time to move things forward :)

@webknjaz
Copy link
Member

Yeah.. I was mostly spotting low-hanging fruit in the first passes, hoping to be able to dedicate an uninterrupted chunk of time to more in-depth reading at some ideal but unspecified moment in time ;)

@befeleme befeleme deleted the pep639 branch January 15, 2025 08:24
@befeleme
Copy link
Contributor Author

Thank you, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A self-contained enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State clearly how a license should be declared
6 participants