-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the specification with PEP 639 #1662
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
e652a7e
to
f5baeba
Compare
@befeleme I've added code suggestions with |
I addressed the review points in the fixup commits for better readability (will squash them later once we get closer to merging). I still walk through the pages looking for the gaps. Thank you for the sphinx tips, that's very helpful! |
22a449c
to
4c81d90
Compare
I think it's ready. |
Is there anything I can do to make this move forward? |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @befeleme!
This comment was marked as resolved.
This comment was marked as resolved.
Copied and adapted from PEP 639.
Redefine the license key, add license-files, mention that license classifiers are deprecated now.
…P 639 Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
22f7db0
to
8ea46cc
Compare
Adapted from: - https://peps.python.org/pep-0639/appendix-examples/ - https://peps.python.org/pep-0639/appendix-user-scenarios/ Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, so I'm taking the view that any further edits and clarifications that folks identify post merge can be tackled in a new PR.
Thanks for the extensive PR @befeleme, and the thorough reviews, all! |
@ncoghlan thanks for merging! I was struggling to find time for a thorough final review myself… |
@webknjaz I admit there was an element of "the goal is 'better than the status quo, not perfect''' in my own final review. I almost put it off again due to the PR size, realised other reviewers were probably doing the same thing, and decided it was time to move things forward :) |
Yeah.. I was mostly spotting low-hanging fruit in the first passes, hoping to be able to dedicate an uninterrupted chunk of time to more in-depth reading at some ideal but unspecified moment in time ;) |
Thank you, all! |
Changed pages:
❓ The meaning of the
license
key in pyproject.toml is changed. The fact that table subkeys are deprecated is mentioned. Should I also keep the previous specification details?❓ Cosmetic "unsureness": keep the changelog at November or antidate it to August when the PEP was provisionally accepted? Since the conditions of acceptance were just recently met, it's high time for these updates.
Resolves #1245.
📚 Documentation preview 📚: