Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling trove classifier verification #1620

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jul 16, 2024

Add a HATCH_METADATA_CLASSIFIERS_NO_VERIFY hook to disable verification of trove classifiers. This makes it possible to build newer packages against old versions of trove-classifiers (or even without the package installed). This is a convenience feature for Linux distributions that do not want to track minimum required trove-classifiers versions as required by various packages.

Fixes #1368

Add a HATCH_NO_VERIFY_TROVE_CLASSIFIERS hook to disable verification
of trove classifiers.  This makes it possible to build newer packages
against old versions of trove-classifiers (or even without the package
installed).  This is a convenience feature for Linux distributions
that do not want to track minimum required trove-classifiers versions
as required by various packages.

Fixes pypa#1368
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the environment variable. Thank you!

@ofek ofek merged commit e1ade75 into pypa:master Nov 10, 2024
50 checks passed
@mgorny mgorny deleted the no-verify-trove-classifiers branch November 10, 2024 03:20
@mgorny
Copy link
Contributor Author

mgorny commented Nov 10, 2024

Thanks!

@smoors
Copy link

smoors commented Dec 20, 2024

I renamed the environment variable. Thank you!

you might want to update the first comment to HATCH_METADATA_CLASSIFIERS_NO_VERIFY

@ofek
Copy link
Collaborator

ofek commented Dec 23, 2024

I don't see which code comment you're referring to

@smoors
Copy link

smoors commented Dec 24, 2024

I don't see which code comment you're referring to

the very first comment at the top of this page. i had to go search for the new name in the code.

@mgorny
Copy link
Contributor Author

mgorny commented Dec 24, 2024

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make trove classifier validation optional/non-fatal
3 participants