Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split pymc_experiments into smaller files #254

Closed

Conversation

jpreszler
Copy link
Contributor

No functional code changes, just splitting into smaller files.

This relates to discussion #253 .

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: Patch coverage is 70.57471% with 128 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (133b987) to head (20fabbc).
Report is 452 commits behind head on main.

Files Patch % Lines
...alpy/pymc_experiments/difference_in_differences.py 61.00% 39 Missing ⚠️
causalpy/pymc_experiments/pre_post_fit.py 59.77% 35 Missing ⚠️
causalpy/pymc_experiments/pre_post_negd.py 67.14% 23 Missing ⚠️
...salpy/pymc_experiments/regression_discontinuity.py 72.83% 22 Missing ⚠️
causalpy/pymc_experiments/experimental_design.py 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   73.89%   74.97%   +1.08%     
==========================================
  Files          19       25       +6     
  Lines        1149     1199      +50     
==========================================
+ Hits          849      899      +50     
  Misses        300      300              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpreszler jpreszler marked this pull request as draft September 27, 2023 14:32
@drbenvincent
Copy link
Collaborator

So this was a good idea, but has been superseded by #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants