as_model wraps function arguments in Data if they support it.
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jan 14, 2025
| @@ -25,5 +25,12 @@ def model_wrapped2(): | |||
|
|
|||
| mw2 = model_wrapped2(coords=coords) | |||
|
|
|||
| @pmx.as_model() | |||
There was a problem hiding this comment.
Can you add an explicitly test with numpy array with nan which should fail when wrapped in pm.Data?
zaxtax
force-pushed
the
add_data_to_as_model
branch
from
b065709 to
66e9d7f
Compare
ricardoV94
approved these changes
Jan 16, 2025
ricardoV94
changed the title
as_model wrap function arguments in Data if they support it.
ricardoV94
changed the title
as_model wrap function arguments in Data if they support it.as_model wraps function arguments in Data if they support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends
as_modelto wrap the function arguments inpm.DataThe motivation for this is that often what gets resampled when running
sample_posterior_predictiveis dependent on what variables are shared. This makes lots of default behaviour less surprising. It also makes it easier to adapt models made withas_modelinto workflows which rely onset_data