-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow sampling in the backgound #94
Conversation
68110b3
to
bdd60ff
Compare
bdd60ff
to
7412e1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat
Is there a way to probe if the sampling is finished without interrupting or blocking? Not clear from skimming the code |
Now there is a |
a24dffa
to
9a33176
Compare
And now also A form of |
@ricardoV94 If you have a minute, this should be ready for review with the new changes again. |
Wanna test some of those methods in the new test? Would be nice to setup some docs to show this functionality, but need not be in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. The inspect
thing will also be great in the future!
This is super cool @aseyboldt !! What I ended up doing is: compiled_model = nutpie.compile_pymc_model(model)
sampler = nutpie.sample(compiled_model, blocking=False, save_warmup=False, store_unconstrained=False)
idata.extend(sampler.abort()) That works, but feels weird from a user perspective. Is this a bug? I'm happy to open an issue if that's helpful |
Allow sampling in the background:
cc @ricardoV94
Also fixes #90