Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate inference results for Tuple[Optional[int], ...] #2340

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Follow-up to #2185. Should help reduce noise in the pylint primer.

@jacobtylerwalls
Copy link
Member Author

Blocked by a pylint patch release

@jacobtylerwalls
Copy link
Member Author

@Pierre-Sassoulas I'd like to unblock this PR so we can get an astroid patch release out and start getting better pylint primer results. We need a pylint patch release with the isort changes to do it, or we could just temporarily pin pylint to main in astroid CI. I'm leaning toward the former, since it's been a couple months since a pylint patch release. WDYT?

This would mean doing things in the reverse order we generally do them (first the pylint patch, then the astroid patch), but then we can upgrade astroid in pylint main without releasing.

@Pierre-Sassoulas
Copy link
Member

I was trying to prepare a pylint patch release "soon" ℒ️, let's release then. (What is in the current milestone are not blockers, only nice to have.)

@jacobtylerwalls jacobtylerwalls merged commit dc13d5b into pylint-dev:main Dec 11, 2023
12 checks passed
@jacobtylerwalls jacobtylerwalls deleted the 9220-duplicate-inference-typing branch December 11, 2023 23:34
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
jacobtylerwalls added a commit that referenced this pull request Dec 12, 2023
) (#2342)

(cherry picked from commit dc13d5b)

Co-authored-by: Jacob Walls <[email protected]>
@Pierre-Sassoulas Pierre-Sassoulas added backported Assigned once the backport is done and removed backport maintenance/3.3.x labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Bug πŸͺ³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[primer noise] deprecated-typing-alias
3 participants