Remove pylint disables and resolves TODO in pylintrc (#2175)

pylint-dev · May 12, 2023 · e1b577a · e1b577a
1 parent 2cd9e90
commit e1b577a
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 7 deletions.
diff --git a/astroid/decorators.py b/astroid/decorators.py
@@ -91,7 +91,6 @@ def inner(
         except StopIteration as error:
             # generator is empty
             if error.args:
-                # pylint: disable=not-a-mapping
                 raise InferenceError(**error.args[0]) from error
             raise InferenceError(
                 "StopIteration raised without any error information."

diff --git a/astroid/manager.py b/astroid/manager.py
@@ -262,7 +262,6 @@ def zip_import_data(self, filepath: str) -> nodes.Module | None:
             except ValueError:
                 continue
             try:
-                # pylint: disable-next=no-member
                 importer = zipimport.zipimporter(eggpath + ext)
                 zmodname = resource.replace(os.path.sep, ".")
                 if importer.is_package(resource):

diff --git a/astroid/nodes/scoped_nodes/scoped_nodes.py b/astroid/nodes/scoped_nodes/scoped_nodes.py
@@ -1751,7 +1751,6 @@ def get_wrapping_class(node):
     return klass
 
 
-# pylint: disable=too-many-instance-attributes
 class ClassDef(
     _base_nodes.FilterStmtsBaseNode, LocalsDictNodeNG, _base_nodes.Statement
 ):

diff --git a/pylintrc b/pylintrc
@@ -259,8 +259,7 @@ mixin-class-rgx=.*Mix[Ii]n
 # List of members which are set dynamically and missed by pylint inference
 # system, and so shouldn't trigger E0201 when accessed. Python regular
 # expressions are accepted.
-# TODO: Remove ast.Match pattern once https://github.com/pylint-dev/pylint/issues/6594 is fixed
-generated-members=REQUEST,acl_users,aq_parent,argparse.Namespace,ast\.([mM]atch.*|pattern)
+generated-members=REQUEST,acl_users,aq_parent,argparse.Namespace
 
 
 [VARIABLES]

diff --git a/tests/brain/test_typing_extensions.py b/tests/brain/test_typing_extensions.py
@@ -9,7 +9,7 @@
 from astroid import builder, nodes
 
 try:
-    import typing_extensions  # pylint: disable=unused-import
+    import typing_extensions
 
     HAS_TYPING_EXTENSIONS = True
     HAS_TYPING_EXTENSIONS_TYPEVAR = hasattr(typing_extensions, "TypeVar")

diff --git a/tests/test_modutils.py b/tests/test_modutils.py
@@ -26,7 +26,7 @@
 from . import resources
 
 try:
-    import urllib3  # type: ignore[import]  # pylint: disable=unused-import
+    import urllib3  # type: ignore[import]
 
     HAS_URLLIB3_V1 = urllib3.__version__.startswith("1")
 except ImportError: